Added fixed SOURCE_DATE_EPOCH flag for reproducible ubuntu builds #8547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilds clnrest's `utoipa-swagger-ui` library has an indirect `rust-embed` dependency which by default includes timestamps in build. It results in non-deterministic build for clnrest. Using environment variable `SOURCE_DATE_EPOCH` with fixed value will enforce a consistent timestamp for builds. Also adding the `--locked` flag to ensure the release build uses exact dependencies from Cargo.lock. The `--locked` flag is particularly important for deterministic builds as it prevents Cargo from updating the lockfile. Fixes ElementsProject#8288. Changelog-Fixed: Core lightning builds for Ubuntu Focal, Jammy and Noble are deterministic again.
Closed
ShahanaFarooqui
requested review from
daywalker90 and
rustyrussell
and removed request for
cdecker
|
Wow great find, back when i tried to fix it my LLM didn't point me to this and now it does... Also the maintainer didn't point me to this either when i implemented my fix with the feature flag. I've built clnrest 3 times in release mode with that ENV set and i got the same hash every time so i'm pretty sure it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clnrest's
utoipa-swagger-uilibrary has an indirectrust-embeddependency which by default includes timestamps in build. It results in non-deterministic build for clnrest. Using environment variableSOURCE_DATE_EPOCHwith fixed value will enforce a consistent timestamp for builds.Also adding the
--lockedflag to ensure the release build uses exact dependencies from Cargo.lock. The--lockedflag is particularly important for deterministic builds as it prevents Cargo from updating the lockfile.Fixes #8288.
Changelog-Fixed: Core lightning builds for Ubuntu Focal, Jammy and Noble are deterministic again.